Made the container uploading and language registration two separate actions #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
requested changes
Nov 24, 2023
exasol_transformers_extension/deployment/language_container_deployer.py
Outdated
Show resolved
Hide resolved
exasol_transformers_extension/deployment/language_container_deployer.py
Outdated
Show resolved
Hide resolved
| """ | ||
| Generates an SQL command to register the SLC container at the required level. The command will | ||
| preserve existing registrations of other containers identified by different language aliases. | ||
| Registration of a container with the same alias, if exists, will be overwritten. |
There was a problem hiding this comment.
I think, for this we should have a option. When set to true we overwrite and if not, we raise an exception
There was a problem hiding this comment.
Do you want to have this option at both API and CLI levels? What should be the default?
There was a problem hiding this comment.
Yeah, I think, it makes sense to have it at both. I am inclined to throw an error when it already exists as the default for the standalone project. And, for the sandbox we would overwrite it always overwrite, because there is the situation different.
MarleneKress79789
requested changes
Nov 24, 2023
|
Fair point about the documentation. Will do. |
tkilias
requested changes
Nov 27, 2023
exasol_transformers_extension/deployment/language_container_deployer.py
Outdated
Show resolved
Hide resolved
exasol_transformers_extension/deployment/language_container_deployer.py
Outdated
Show resolved
Hide resolved
tkilias
requested changes
Nov 28, 2023
tkilias
requested changes
Nov 28, 2023
exasol_transformers_extension/deployment/language_container_deployer_cli.py
Outdated
Show resolved
Hide resolved
tkilias
approved these changes
Nov 28, 2023
MarleneKress79789
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #151
It also fixes a couple of broken integration tests, with one - test_model_downloader_udf_script - yet to be fixed.